-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kvm2 --version #4398
Add kvm2 --version #4398
Conversation
Can one of the admins verify this patch? |
Hi @josedonizetti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e256d46
to
a024c6d
Compare
@minikube-bot OK test |
@josedonizetti thank for your contributions, would you please add documentation and integration tests for it ? and how one would use this --version ? |
@medyagh The usage will be |
@medyagh @josedonizetti I think it should be |
@blueelvis I think the command |
@medyagh Hey, have any pointers on adding integration tests for this? |
FIx #4387
Considerations:
minikube/version
--version
, I didn't use cobra/viperLet me know what you think. I'll add it to hyperkit, once this one was approved.