Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kvm2 --version #4398

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Conversation

josedonizetti
Copy link
Member

FIx #4387

Considerations:

  • I've added a version.go to the kvm driver instead of importing minikube/version
  • As we are only supporting --version, I didn't use cobra/viper

Let me know what you think. I'll add it to hyperkit, once this one was approved.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jun 6, 2019

@minikube-bot OK test

@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2019
@medyagh
Copy link
Member

medyagh commented Jun 6, 2019

@josedonizetti thank for your contributions, would you please add documentation and integration tests for it ? and how one would use this --version ?

@josedonizetti
Copy link
Member Author

@medyagh The usage will be docker-machine-driver-kvm2 --version. The idea is to simplify issues communication about the kvm2 driver, the user would have a simple way to know the driver is outdated, and probably the reason it's currently failing. I'll add the documentation and tests. Thanks

@blueelvis
Copy link
Contributor

@medyagh @josedonizetti I think it should be --kvm-version instead of just --version. That way, people don't get confused if that is the minikube's version or the kvm driver version. What do you think?

@josedonizetti
Copy link
Member Author

@blueelvis I think the command docker-machine-driver-kvm2 --version is very explanatory that is not the same as minikube --version. Yet, no strong feelings about it, let's see what others think. :)

@tstromberg tstromberg merged commit 4610663 into kubernetes:master Jun 19, 2019
@josedonizetti josedonizetti deleted the add-kvm-version-flag branch June 25, 2019 17:20
@josedonizetti
Copy link
Member Author

@medyagh Hey, have any pointers on adding integration tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --version to kvm2 driver
6 participants